Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show counts on entity list tabs #2169

Merged
merged 9 commits into from
Jan 4, 2022

Conversation

kermieisinthehouse
Copy link
Collaborator

This adds counts to the tabs under a performer, studio, or tag.

The only one missing is Studio > Performers Tab, as the API just doesn't provide it for some reason.

E.g. for a performer:
Screenshot from 2021-12-27 06-22-32

@kermieisinthehouse kermieisinthehouse added this to the Version 0.13.0 milestone Dec 27, 2021
@kermieisinthehouse kermieisinthehouse added improvement Something needed tweaking. ui Issues related to UI labels Dec 27, 2021
@kermieisinthehouse kermieisinthehouse changed the title Show stats on entity list tabs Show counts on entity list tabs Dec 27, 2021
bnkai
bnkai previously approved these changes Dec 30, 2021
@bnkai bnkai dismissed their stale review December 30, 2021 18:05

discord feedback

@bnkai
Copy link
Collaborator

bnkai commented Dec 30, 2021

Feedback from the discord channel (UI/number format) and testing
Number.toLocaleString() uses the browser language (navigator.languages[0]) and not the Stash language set by the user
To reproduce

  • set language to German
  • go to tags page (or any page that has a lot of count)
  • 1-40 of 2.104 is shown for the tags count
  • 11,204 is shown for my most used tag
    . vs ,

@kermieisinthehouse
Copy link
Collaborator Author

Saw it on discord, will patch this soon. Thanks!

@kermieisinthehouse
Copy link
Collaborator Author

Fixed now

@WithoutPants WithoutPants merged commit 90a4931 into stashapp:develop Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking. ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants